Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c11760c6 authored by Linus Torvalds's avatar Linus Torvalds
Browse files

isofs: fix bh leak in isofs_fill_super() error case 



In isofs_fill_super(), when an iso_primary_descriptor is found, it is
kept in pri_bh.  The error cases don't properly release it.  Fix it.

Reported-and-tested-by: default avatar김원석 <stanley.will.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent a6c0a392

fs/isofs/inode.c

+2 −1
Original line number Diff line number Diff line
@@ -974,7 +974,7 @@ static int isofs_fill_super(struct super_block *s, void *data, int silent) 
out_no_read:

	printk(KERN_WARNING "%s: bread failed, dev=%s, iso_blknum=%d, block=%d\n",

		__func__, s->s_id, iso_blknum, block);

	goto out_freesbi;

	goto out_freebh;

out_bad_zone_size:

	printk(KERN_WARNING "ISOFS: Bad logical zone size %ld\n",

		sbi->s_log_zone_size);
@@ -989,6 +989,7 @@ static int isofs_fill_super(struct super_block *s, void *data, int silent) 


out_freebh:

	brelse(bh);

	brelse(pri_bh);

out_freesbi:

	kfree(opt.iocharset);

	kfree(sbi);