Commit c10edee2 authored Nov 08, 2009 by Pekka Enberg Committed by Ingo Molnar Nov 08, 2009

perf tools: Fix permission checks



The perf_event_open() system call returns EACCES if the user is
not root which results in a very confusing error message:

  $ perf record -A -a -f

    Error: perfcounter syscall returned with -1 (Permission denied)

    Fatal: No CONFIG_PERF_EVENTS=y kernel support configured?

It turns out that's because perf tools are checking only for
EPERM. Fix that up to get a much better error message:

  $ perf record -A -a -f
    Fatal: Permission error - are you root?

Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <1257696066-4046-1-git-send-email-penberg@cs.helsinki.fi>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent dd77038d

tools/perf/builtin-record.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -426,7 +426,7 @@ static void create_counter(int counter, int cpu, pid_t pid)
		if (fd[nr_cpu][counter] < 0) {
		int err = errno;

		if (err == EPERM)
		if (err == EPERM \|\| err == EACCES)
		die("Permission error - are you root?\n");
		else if (err == ENODEV && profile_cpu != -1)
		die("No such device - did you specify an out-of-range profile CPU?\n");

tools/perf/builtin-top.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1027,7 +1027,7 @@ static void start_counter(int i, int counter)
		if (fd[i][counter] < 0) {
		int err = errno;

		if (err == EPERM)
		if (err == EPERM \|\| err == EACCES)
		die("No permission - are you root?\n");
		/*
		* If it's cycles then fall back to hrtimer