Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c0d92cbc authored by Pekka J Enberg's avatar Pekka J Enberg Committed by Linus Torvalds
Browse files

[PATCH] libfs: remove page up-to-date check from simple_readpage 



Remove the unnecessary PageUptodate check from simple_readpage.  The only
two callers for ->readpage that don't have explicit PageUptodate check are
read_cache_pages and page_cache_read which operate on newly allocated pages
which don't have the flag set.

[akpm: use the allegedly-faster clear_page(), too]
Signed-off-by: default avatarPekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent cfedc920

fs/libfs.c

+1 −9
Original line number Diff line number Diff line
@@ -317,17 +317,9 @@ int simple_rename(struct inode *old_dir, struct dentry *old_dentry, 


int simple_readpage(struct file *file, struct page *page)

{

	void *kaddr;



	if (PageUptodate(page))

		goto out;



	kaddr = kmap_atomic(page, KM_USER0);

	memset(kaddr, 0, PAGE_CACHE_SIZE);

	kunmap_atomic(kaddr, KM_USER0);

	clear_highpage(page);

	flush_dcache_page(page);

	SetPageUptodate(page);

out:

	unlock_page(page);

	return 0;

}