Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c078f0dd authored by Tadeusz Struk's avatar Tadeusz Struk Committed by Doug Ledford
Browse files

IB/hfi1: Fix potential buffer overflow 



This fixes potential buffer overflow because the sprintf function
doesn't check buffer boundaries. Use snprintf instead.

Reviewed-by: default avatarDennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: default avatarTadeusz Struk <tadeusz.struk@intel.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 93dd0a09

drivers/infiniband/hw/hfi1/qsfp.c

+2 −1
Original line number Diff line number Diff line
@@ -579,7 +579,8 @@ int qsfp_dump(struct hfi1_pportdata *ppd, char *buf, int len) 


	if (ppd->qsfp_info.cache_valid) {

		if (QSFP_IS_CU(cache[QSFP_MOD_TECH_OFFS]))

			sprintf(lenstr, "%dM ", cache[QSFP_MOD_LEN_OFFS]);

			snprintf(lenstr, sizeof(lenstr), "%dM ",

				 cache[QSFP_MOD_LEN_OFFS]);



		power_byte = cache[QSFP_MOD_PWR_OFFS];

		sofar += scnprintf(buf + sofar, len - sofar, "PWR:%.3sW\n",