Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c0754c99 authored by Alan Cox's avatar Alan Cox Committed by Linus Torvalds
Browse files

68360serial: Note that there isn't any info->mcr locking 



Noticed while auditing the code for the BKL elimination project

Signed-off-by: default avatarAlan Cox <alan@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 6e4d376c

drivers/serial/68360serial.c

+1 −1
Original line number Diff line number Diff line
@@ -1282,7 +1282,7 @@ static int rs_360_tiocmset(struct tty_struct *tty, struct file *file, 


	if (tty->flags & (1 << TTY_IO_ERROR))

		return -EIO;



	/* FIXME: locking on info->mcr */

 	if (set & TIOCM_RTS)

 		info->mcr |= UART_MCR_RTS;

 	if (set & TIOCM_DTR)