Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c06c066a authored by Aneesh Kumar K.V's avatar Aneesh Kumar K.V Committed by Eric Van Hensbergen
Browse files

fs/9p: Properly update inode attributes on link 



With caching enabled, we need to make sure we don't
update inode->i_size via stat2inode because we could
have dirty data which is not yet written to the server

Signed-off-by: default avatarAneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: default avatarVenkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
Signed-off-by: default avatarEric Van Hensbergen <ericvh@gmail.com>
parent e0459f57

fs/9p/vfs_inode.c

+3 −1
Original line number Diff line number Diff line
@@ -1292,8 +1292,10 @@ v9fs_vfs_link(struct dentry *old_dentry, struct inode *dir, 
	sprintf(name, "%d\n", oldfid->fid);

	retval = v9fs_vfs_mkspecial(dir, dentry, P9_DMLINK, name);

	__putname(name);

	if (!retval)

	if (!retval) {

		v9fs_refresh_inode(oldfid, old_dentry->d_inode);

		v9fs_invalidate_inode_attr(dir);

	}

clunk_fid:

	p9_client_clunk(oldfid);

	return retval;

fs/9p/vfs_inode_dotl.c

+1 −9
Original line number Diff line number Diff line
@@ -671,19 +671,11 @@ v9fs_vfs_link_dotl(struct dentry *old_dentry, struct inode *dir, 
	if (v9ses->cache == CACHE_LOOSE || v9ses->cache == CACHE_FSCACHE) {

		/* Get the latest stat info from server. */

		struct p9_fid *fid;

		struct p9_stat_dotl *st;



		fid = v9fs_fid_lookup(old_dentry);

		if (IS_ERR(fid))

			return PTR_ERR(fid);



		st = p9_client_getattr_dotl(fid, P9_STATS_BASIC);

		if (IS_ERR(st))

			return PTR_ERR(st);



		v9fs_stat2inode_dotl(st, old_dentry->d_inode);



		kfree(st);

		v9fs_refresh_inode_dotl(fid, old_dentry->d_inode);

	}

	ihold(old_dentry->d_inode);

	d_instantiate(dentry, old_dentry->d_inode);