Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c0569981 authored by Julia Lawall's avatar Julia Lawall Committed by Greg Kroah-Hartman
Browse files

drivers/staging/mei/interface.c: take size of pointed value, not pointer 

Sizeof a pointer-typed expression returns the size of the pointer, not that
of the pointed data.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression *e;
type T;
identifier f;
@@

f(...,(T)e,...,
-sizeof(e)
+sizeof(*e)
,...)
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 661d3bf6

drivers/staging/mei/interface.c

+2 −2
Original line number Diff line number Diff line
@@ -332,7 +332,7 @@ int mei_send_flow_control(struct mei_device *dev, struct mei_cl *cl) 
	mei_hdr->reserved = 0;



	mei_flow_control = (struct hbm_flow_control *) &dev->wr_msg_buf[1];

	memset(mei_flow_control, 0, sizeof(mei_flow_control));

	memset(mei_flow_control, 0, sizeof(*mei_flow_control));

	mei_flow_control->host_addr = cl->host_client_id;

	mei_flow_control->me_addr = cl->me_client_id;

	mei_flow_control->cmd.cmd = MEI_FLOW_CONTROL_CMD;
@@ -396,7 +396,7 @@ int mei_disconnect(struct mei_device *dev, struct mei_cl *cl) 


	mei_cli_disconnect =

	    (struct hbm_client_disconnect_request *) &dev->wr_msg_buf[1];

	memset(mei_cli_disconnect, 0, sizeof(mei_cli_disconnect));

	memset(mei_cli_disconnect, 0, sizeof(*mei_cli_disconnect));

	mei_cli_disconnect->host_addr = cl->host_client_id;

	mei_cli_disconnect->me_addr = cl->me_client_id;

	mei_cli_disconnect->cmd.cmd = CLIENT_DISCONNECT_REQ_CMD;