Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bf7b8760 authored by Michael Buesch's avatar Michael Buesch Committed by John W. Linville
Browse files

[PATCH] bcm43xx: Workaround init_board vs IRQ race. 



The proper fix for this is to move IRQ enabling to the end of
init_board. But this is nontrivial and needs to be done with care.
Stay with this cheap workaround for now.

Signed-off-by: default avatarMichael Buesch <mbuesch@freenet.de>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent c4c3beb7

drivers/net/wireless/bcm43xx/bcm43xx_main.c

+13 −6
Original line number Diff line number Diff line
@@ -2079,12 +2079,19 @@ static irqreturn_t bcm43xx_interrupt_handler(int irq, void *dev_id, struct pt_re 


	bcm43xx_interrupt_ack(bcm, reason, mask);



	/* Only accept IRQs, if we are initialized properly.

	 * This avoids an RX race while initializing.

	 * We should probably not enable IRQs before we are initialized

	 * completely, but some careful work is needed to fix this. I think it

	 * is best to stay with this cheap workaround for now... .

	 */

	if (likely(bcm->initialized)) {

		/* disable all IRQs. They are enabled again in the bottom half. */

		bcm->irq_savedstate = bcm43xx_interrupt_disable(bcm, BCM43xx_IRQ_ALL);



		/* save the reason code and call our bottom half. */

		bcm->irq_reason = reason;

		tasklet_schedule(&bcm->isr_tasklet);

	}



	spin_unlock(&bcm->lock);