Commit bed0415e authored Mar 26, 2022 by Fabio Estevam Committed by Greg Kroah-Hartman May 12, 2022

ARM: dts: imx6qdl-apalis: Fix sgtl5000 detection issue



[ Upstream commit fa51e1dc4b91375bc18349663a52395ad585bd3c ]

On a custom carrier board with a i.MX6Q Apalis SoM, the sgtl5000 codec
on the SoM is often not detected and the following error message is
seen when the sgtl5000 driver tries to read the ID register:

sgtl5000 1-000a: Error reading chip id -6

The reason for the error is that the MCLK clock is not provided
early enough.

Fix the problem by describing the MCLK pinctrl inside the codec
node instead of placing it inside the audmux pinctrl group.

With this change applied the sgtl5000 is always detected on every boot.

Fixes: 693e3ffa ("ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM")
Signed-off-by: Fabio Estevam <festevam@gmail.com>
Reviewed-by: Tim Harvey <tharvey@gateworks.com>
Acked-by: Max Krummenacher <max.krummenacher@toradex.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent c419dc1f

arch/arm/boot/dts/imx6qdl-apalis.dtsi

+8 −2

Original line number	Diff line number	Diff line
		@@ -324,6 +324,8 @@
		codec: sgtl5000@0a {
		compatible = "fsl,sgtl5000";
		reg = <0x0a>;
		pinctrl-names = "default";
		pinctrl-0 = <&pinctrl_sgtl5000>;
		clocks = <&clks IMX6QDL_CLK_CKO>;
		VDDA-supply = <&reg_2p5v>;
		VDDIO-supply = <&reg_3p3v>;
		@@ -550,8 +552,6 @@
		MX6QDL_PAD_DISP0_DAT21__AUD4_TXD 0x130b0
		MX6QDL_PAD_DISP0_DAT22__AUD4_TXFS 0x130b0
		MX6QDL_PAD_DISP0_DAT23__AUD4_RXD 0x130b0
		/* SGTL5000 sys_mclk */
		MX6QDL_PAD_GPIO_5__CCM_CLKO1 0x130b0
		>;
		};

		@@ -812,6 +812,12 @@
		>;
		};

		pinctrl_sgtl5000: sgtl5000grp {
		fsl,pins = <
		MX6QDL_PAD_GPIO_5__CCM_CLKO1 0x130b0
		>;
		};

		pinctrl_spdif: spdifgrp {
		fsl,pins = <
		MX6QDL_PAD_GPIO_16__SPDIF_IN 0x1b0b0