Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bdfd36ef authored by Ville Syrjälä's avatar Ville Syrjälä Committed by Vincent Abriou
Browse files

drm/sti: Fix sparse warnings 



drm/sti/sti_mixer.c:361:6: warning: symbol 'sti_mixer_set_matrix' was not declared. Should it be static?
drm/sti/sti_gdp.c:476:5: warning: symbol 'sti_gdp_field_cb' was not declared. Should it be static?
drm/sti/sti_gdp.c:885:24: warning: symbol 'sti_gdp_plane_helpers_funcs' was not declared. Should it be static?
drm/sti/sti_cursor.c:348:24: warning: symbol 'sti_cursor_plane_helpers_funcs' was not declared. Should it be static?
drm/sti/sti_compositor.c:28:28: warning: symbol 'stih407_compositor_data' was not declared. Should it be static?
drm/sti/sti_compositor.c:49:28: warning: symbol 'stih416_compositor_data' was not declared. Should it be static?
drm/sti/sti_vtg.c:75:1: warning: symbol 'vtg_lookup' was not declared. Should it be static?
drm/sti/sti_vtg.c:476:24: warning: symbol 'sti_vtg_driver' was not declared. Should it be static?
drm/sti/sti_dvo.c:109:5: warning: symbol 'dvo_awg_generate_code' was not declared. Should it be static?
drm/sti/sti_dvo.c:602:24: warning: symbol 'sti_dvo_driver' was not declared. Should it be static?
drm/sti/sti_vtac.c:209:24: warning: symbol 'sti_vtac_driver' was not declared. Should it be static?
drm/sti/sti_tvout.c:914:24: warning: symbol 'sti_tvout_driver' was not declared. Should it be static?
drm/sti/sti_hqvdp.c:786:5: warning: symbol 'sti_hqvdp_vtg_cb' was not declared. Should it be static?
drm/sti/sti_hqvdp.c:1253:24: warning: symbol 'sti_hqvdp_plane_helpers_funcs' was not declared. Should it be static?
drm/sti/sti_hqvdp.c:1292:5: warning: symbol 'sti_hqvdp_bind' was not declared. Should it be static?
drm/sti/sti_hqvdp.c:1385:24: warning: symbol 'sti_hqvdp_driver' was not declared. Should it be static?
drm/sti/sti_drv.c:143:6: warning: symbol 'sti_drm_dbg_cleanup' was not declared. Should it be static?

Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: Vincent Abriou <vincent.abriou@st.com>
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Acked-by: default avatarVincent Abriou <vincent.abriou@st.com>
parent 7c0ca70b

drivers/gpu/drm/sti/sti_compositor.c

+2 −2
Original line number Diff line number Diff line
@@ -25,7 +25,7 @@ 
/*

 * stiH407 compositor properties

 */

struct sti_compositor_data stih407_compositor_data = {

static const struct sti_compositor_data stih407_compositor_data = {

	.nb_subdev = 8,

	.subdev_desc = {

			{STI_CURSOR_SUBDEV, (int)STI_CURSOR, 0x000},
@@ -46,7 +46,7 @@ struct sti_compositor_data stih407_compositor_data = { 
 * Moreover, GDPx is different for Main and Aux Mixer. So this subdev map does

 * not fit for stiH416 if we want to enable the MIXER_AUX.

 */

struct sti_compositor_data stih416_compositor_data = {

static const struct sti_compositor_data stih416_compositor_data = {

	.nb_subdev = 3,

	.subdev_desc = {

			{STI_GPD_SUBDEV, (int)STI_GDP_0, 0x100},

drivers/gpu/drm/sti/sti_cursor.c

+1 −1
Original line number Diff line number Diff line
@@ -345,7 +345,7 @@ static int sti_cursor_late_register(struct drm_plane *drm_plane) 
	return cursor_debugfs_init(cursor, drm_plane->dev->primary);

}



struct drm_plane_funcs sti_cursor_plane_helpers_funcs = {

static const struct drm_plane_funcs sti_cursor_plane_helpers_funcs = {

	.update_plane = drm_atomic_helper_update_plane,

	.disable_plane = drm_atomic_helper_disable_plane,

	.destroy = sti_cursor_destroy,

drivers/gpu/drm/sti/sti_drv.c

+1 −1
Original line number Diff line number Diff line
@@ -140,7 +140,7 @@ static int sti_drm_dbg_init(struct drm_minor *minor) 
	return ret;

}



void sti_drm_dbg_cleanup(struct drm_minor *minor)

static void sti_drm_dbg_cleanup(struct drm_minor *minor)

{

	drm_debugfs_remove_files(sti_drm_dbg_list,

				 ARRAY_SIZE(sti_drm_dbg_list), minor);

drivers/gpu/drm/sti/sti_dvo.c

+2 −1
Original line number Diff line number Diff line
@@ -17,6 +17,7 @@ 
#include <drm/drm_panel.h>



#include "sti_awg_utils.h"

#include "sti_drv.h"

#include "sti_mixer.h"



/* DVO registers */
@@ -106,7 +107,7 @@ struct sti_dvo_connector { 
	container_of(x, struct sti_dvo_connector, drm_connector)



#define BLANKING_LEVEL 16

int dvo_awg_generate_code(struct sti_dvo *dvo, u8 *ram_size, u32 *ram_code)

static int dvo_awg_generate_code(struct sti_dvo *dvo, u8 *ram_size, u32 *ram_code)

{

	struct drm_display_mode *mode = &dvo->mode;

	struct dvo_config *config = dvo->config;

drivers/gpu/drm/sti/sti_gdp.c

+3 −3
Original line number Diff line number Diff line
@@ -473,7 +473,7 @@ static void sti_gdp_disable(struct sti_gdp *gdp) 
 * RETURNS:

 * 0 on success.

 */

int sti_gdp_field_cb(struct notifier_block *nb,

static int sti_gdp_field_cb(struct notifier_block *nb,

			    unsigned long event, void *data)

{

	struct sti_gdp *gdp = container_of(nb, struct sti_gdp, vtg_field_nb);
@@ -882,7 +882,7 @@ static int sti_gdp_late_register(struct drm_plane *drm_plane) 
	return gdp_debugfs_init(gdp, drm_plane->dev->primary);

}



struct drm_plane_funcs sti_gdp_plane_helpers_funcs = {

static const struct drm_plane_funcs sti_gdp_plane_helpers_funcs = {

	.update_plane = drm_atomic_helper_update_plane,

	.disable_plane = drm_atomic_helper_disable_plane,

	.destroy = sti_gdp_destroy,