Commit bd4060a6 authored Jul 16, 2015 by Florian Fainelli Committed by David S. Miller Jul 20, 2015

net: bcmgenet: Power on integrated GPHY in bcmgenet_power_up()



We are currently disabling the GPHY interface during bcmgenet_close(),
and attempting to power it back on during bcmgenet_open(). This works
fine for the first time, because we called bcmgenet_mii_config() which
took care of enabling the interface, however, bcmgenet_power_up() really
needs to power on the GPHY for correctness.

This will be particularly important as we want to move
bcmgenet_mii_probe() down to bcmgenet_open() to avoid seeing the "PHY
already attached" message.

Fixes: a642c4f7 ("net: bcmgenet: power up and down integrated GPHY when unused")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 978ffac4

drivers/net/ethernet/broadcom/genet/bcmgenet.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -907,6 +907,8 @@ static void bcmgenet_power_up(struct bcmgenet_priv *priv,
		}

		bcmgenet_ext_writel(priv, reg, EXT_EXT_PWR_MGMT);
		if (mode == GENET_POWER_PASSIVE)
		bcmgenet_phy_power_set(priv->dev, true);
		}

		/* ioctl handle special commands that are not present in ethtool. */