Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bd2fe272 authored by Paul Gortmaker's avatar Paul Gortmaker Committed by Greg Kroah-Hartman
Browse files

drivers/tty/serial: deal with 8250_core.c uninitialized warning for good 

Every couple of months, someone sends a patch to fix:

drivers/tty/serial/8250/8250_core.c: In function 'serial_unlink_irq_chain':
drivers/tty/serial/8250/8250_core.c:1712:2: warning: 'i' may be used uninitialized in this function [-Wuninitialized]

and they in turn get a NACK for their efforts, and are told that
their compiler is broken.  This has been going on since at least
the year 2008:  https://lkml.org/lkml/2008/11/24/433



Lets add a comment, so that subsequent patches don't get as far as
the maintainers or the mailing lists.

Acked-by: default avatarAlan Cox <alan@linux.intel.com>
Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8301bb24

drivers/tty/serial/8250/8250_core.c

+4 −0
Original line number Diff line number Diff line
@@ -1694,6 +1694,10 @@ static int serial_link_irq_chain(struct uart_8250_port *up) 


static void serial_unlink_irq_chain(struct uart_8250_port *up)

{

	/*

	 * yes, some broken gcc emit "warning: 'i' may be used uninitialized"

	 * but no, we are not going to take a patch that assigns NULL below.

	 */

	struct irq_info *i;

	struct hlist_node *n;

	struct hlist_head *h;