Commit bc3b5b47 authored Feb 25, 2015 by Dan Carpenter Committed by Bjorn Helgaas Mar 12, 2015

PCI: cpcihp: Add missing curly braces in cpci_configure_slot()



I don't have this hardware but it looks like we weren't adding bridge
devices as intended.  Maybe the bridge is always the last device?

Fixes: 05b12500 ("PCI: cpcihp: Iterate over all devices in slot, not functions 0-7")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Yijing Wang <wangyijing@huawei.com>
CC: stable@vger.kernel.org	# v3.9+

parent a1b7f2f6

drivers/pci/hotplug/cpci_hotplug_pci.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -286,11 +286,12 @@ int cpci_configure_slot(struct slot *slot)
		}
		parent = slot->dev->bus;

		list_for_each_entry(dev, &parent->devices, bus_list)
		list_for_each_entry(dev, &parent->devices, bus_list) {
		if (PCI_SLOT(dev->devfn) != PCI_SLOT(slot->devfn))
		continue;
		if (pci_is_bridge(dev))
		pci_hp_add_bridge(dev);
		}


		pci_assign_unassigned_bridge_resources(parent->self);