Commit bc03249a authored Apr 24, 2022 by Lv Ruyi Committed by Greg Kroah-Hartman May 12, 2022

pinctrl: pistachio: fix use of irq_of_parse_and_map()



[ Upstream commit 0c9843a74a85224a89daa81fa66891dae2f930e1 ]

The irq_of_parse_and_map() function returns 0 on failure, and does not
return an negative value.

Fixes: cefc03e5 ("pinctrl: Add Pistachio SoC pin control driver")
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Link: https://lore.kernel.org/r/20220424031430.3170759-1-lv.ruyi@zte.com.cn


Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 953345b8

drivers/pinctrl/pinctrl-pistachio.c

+3 −3

Original line number	Original line	Diff line number	Diff line
	@@ -1374,10 +1374,10 @@ static int pistachio_gpio_register(struct pistachio_pinctrl *pctl)
	}		}

	irq = irq_of_parse_and_map(child, 0);		irq = irq_of_parse_and_map(child, 0);
	if (irq < 0) {		if (!irq) {
	dev_err(pctl->dev, "No IRQ for bank %u: %d\n", i, irq);		dev_err(pctl->dev, "No IRQ for bank %u\n", i);
	of_node_put(child);		of_node_put(child);
	ret = irq;		ret = -EINVAL;
	goto err;		goto err;
	}		}