Commit bbd53d05 authored Nov 09, 2022 by Yang Yingliang Committed by Greg Kroah-Hartman Nov 25, 2022

mISDN: fix possible memory leak in mISDN_dsp_element_register()



[ Upstream commit 98a2ac1ca8fd6eca6867726fe238d06e75eb1acd ]

Afer commit 1fa5ae85 ("driver core: get rid of struct device's
bus_id string array"), the name of device is allocated dynamically,
use put_device() to give up the reference, so that the name can be
freed in kobject_cleanup() when the refcount is 0.

The 'entry' is going to be freed in mISDN_dsp_dev_release(), so the
kfree() is removed. list_del() is called in mISDN_dsp_dev_release(),
so it need be initialized.

Fixes: 1fa5ae85 ("driver core: get rid of struct device's bus_id string array")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221109132832.3270119-1-yangyingliang@huawei.com


Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent aaf552c5

drivers/isdn/mISDN/dsp_pipeline.c

+2 −1

Original line number	Original line	Diff line number	Diff line
	@@ -97,6 +97,7 @@ int mISDN_dsp_element_register(struct mISDN_dsp_element *elem)
	if (!entry)		if (!entry)
	return -ENOMEM;		return -ENOMEM;

			INIT_LIST_HEAD(&entry->list);
	entry->elem = elem;		entry->elem = elem;

	entry->dev.class = elements_class;		entry->dev.class = elements_class;
	@@ -131,7 +132,7 @@ int mISDN_dsp_element_register(struct mISDN_dsp_element *elem)
	device_unregister(&entry->dev);		device_unregister(&entry->dev);
	return ret;		return ret;
	err1:		err1:
	kfree(entry);		put_device(&entry->dev);
	return ret;		return ret;
	}		}
	EXPORT_SYMBOL(mISDN_dsp_element_register);		EXPORT_SYMBOL(mISDN_dsp_element_register);