Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bb7a8c8e authored by Nicholas Bellinger's avatar Nicholas Bellinger
Browse files

target: Fix exception path pr_reg put regression for PR RELEASE 



Fix a regression bug in core_scsi3_emulate_pro_release() where
should still be getting released via core_scsi3_put_pr_reg() during
No persistent reservation, with returing GOOD status.

Use goto statement here to follow converted code from hch.

Cc: Christoph Hellwig <hch@lst.de>
Cc: Roland Dreier <roland@purestorage.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent b69c1fcf

drivers/target/target_core_pr.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -2604,7 +2604,7 @@ core_scsi3_emulate_pro_release(struct se_cmd *cmd, int type, int scope, 
		 * No persistent reservation, return GOOD status.

		 * No persistent reservation, return GOOD status.

		 */

		 */

		spin_unlock(&dev->dev_reservation_lock);

		spin_unlock(&dev->dev_reservation_lock);

		return 0;

		goto out_put_pr_reg;

	}

	}

	if ((pr_res_holder->pr_res_type == PR_TYPE_WRITE_EXCLUSIVE_ALLREG) ||

	if ((pr_res_holder->pr_res_type == PR_TYPE_WRITE_EXCLUSIVE_ALLREG) ||

	    (pr_res_holder->pr_res_type == PR_TYPE_EXCLUSIVE_ACCESS_ALLREG))

	    (pr_res_holder->pr_res_type == PR_TYPE_EXCLUSIVE_ACCESS_ALLREG))