Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ba13e98f authored by Sean Young's avatar Sean Young Committed by Linus Torvalds
Browse files

dib0700: fix nec repeat handling 



When receiving a nec repeat, ensure the correct scancode is repeated
rather than a random value from the stack.  This removes the need for
the bogus uninitialized_var() and also fixes the warnings:

    drivers/media/usb/dvb-usb/dib0700_core.c: In function ‘dib0700_rc_urb_completion’:
    drivers/media/usb/dvb-usb/dib0700_core.c:679: warning: ‘protocol’ may be used uninitialized in this function

[sean addon: So after writing the patch and submitting it, I've bought the
             hardware on ebay. Without this patch you get random scancodes
             on nec repeats, which the patch indeed fixes.]

Signed-off-by: default avatarSean Young <sean@mess.org>
Tested-by: default avatarSean Young <sean@mess.org>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 92dfffee

drivers/media/usb/dvb-usb/dib0700_core.c

+3 −2
Original line number Diff line number Diff line
@@ -704,7 +704,7 @@ static void dib0700_rc_urb_completion(struct urb *purb) 
	struct dvb_usb_device *d = purb->context;

	struct dib0700_rc_response *poll_reply;

	enum rc_type protocol;

	u32 uninitialized_var(keycode);

	u32 keycode;

	u8 toggle;



	deb_info("%s()\n", __func__);
@@ -745,7 +745,8 @@ static void dib0700_rc_urb_completion(struct urb *purb) 
		    poll_reply->nec.data       == 0x00 &&

		    poll_reply->nec.not_data   == 0xff) {

			poll_reply->data_state = 2;

			break;

			rc_repeat(d->rc_dev);

			goto resubmit;

		}



		if ((poll_reply->nec.data ^ poll_reply->nec.not_data) != 0xff) {