Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b9454f90 authored by Tal Shorer's avatar Tal Shorer Committed by Felipe Balbi
Browse files

usb: ulpi: make ops struct constant 



None of the core ulpi functions perform any changes to the operations
struct, and logically as a struct that contains function pointers
there's no reason it shouldn't be constant.

Acked-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: default avatarTal Shorer <tal.shorer@gmail.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent 042b0f31

drivers/usb/common/ulpi.c

+2 −1
Original line number Original line Diff line number Diff line
@@ -202,7 +202,8 @@ static int ulpi_register(struct device *dev, struct ulpi *ulpi) 
 * Allocates and registers a ULPI device and an interface for it. Called from

 * Allocates and registers a ULPI device and an interface for it. Called from

 * the USB controller that provides the ULPI interface.

 * the USB controller that provides the ULPI interface.

 */

 */

struct ulpi *ulpi_register_interface(struct device *dev, struct ulpi_ops *ops)

struct ulpi *ulpi_register_interface(struct device *dev,

				     const struct ulpi_ops *ops)

{

{

	struct ulpi *ulpi;

	struct ulpi *ulpi;

	int ret;

	int ret;

include/linux/ulpi/driver.h

+1 −1
Original line number Original line Diff line number Diff line
@@ -15,7 +15,7 @@ struct ulpi_ops; 
 */

 */

struct ulpi {

struct ulpi {

	struct ulpi_device_id id;

	struct ulpi_device_id id;

	struct ulpi_ops *ops;

	const struct ulpi_ops *ops;

	struct device dev;

	struct device dev;

};

};

include/linux/ulpi/interface.h

+1 −1
Original line number Original line Diff line number Diff line
@@ -16,7 +16,7 @@ struct ulpi_ops { 
	int (*write)(struct device *dev, u8 addr, u8 val);

	int (*write)(struct device *dev, u8 addr, u8 val);

};

};





struct ulpi *ulpi_register_interface(struct device *, struct ulpi_ops *);

struct ulpi *ulpi_register_interface(struct device *, const struct ulpi_ops *);

void ulpi_unregister_interface(struct ulpi *);

void ulpi_unregister_interface(struct ulpi *);





#endif /* __LINUX_ULPI_INTERFACE_H */
 
#endif /* __LINUX_ULPI_INTERFACE_H */