Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b8d966ef authored by NeilBrown's avatar NeilBrown
Browse files

md: avoid dereferencing NULL pointer when accessing suspend_* sysfs attributes. 



If we try to modify one of the md/ sysfs files
  suspend_lo or suspend_hi
when the array is not active, we dereference a NULL.
Protect against that.

Cc: stable@kernel.org
Signed-off-by: default avatarNeilBrown <neilb@suse.de>
parent 8f6c2e4b

drivers/md/md.c

+4 −2
Original line number Diff line number Diff line
@@ -3573,7 +3573,8 @@ suspend_lo_store(mddev_t *mddev, const char *buf, size_t len) 
	char *e;

	unsigned long long new = simple_strtoull(buf, &e, 10);



	if (mddev->pers->quiesce == NULL)

	if (mddev->pers == NULL || 

	    mddev->pers->quiesce == NULL)

		return -EINVAL;

	if (buf == e || (*e && *e != '\n'))

		return -EINVAL;
@@ -3601,7 +3602,8 @@ suspend_hi_store(mddev_t *mddev, const char *buf, size_t len) 
	char *e;

	unsigned long long new = simple_strtoull(buf, &e, 10);



	if (mddev->pers->quiesce == NULL)

	if (mddev->pers == NULL ||

	    mddev->pers->quiesce == NULL)

		return -EINVAL;

	if (buf == e || (*e && *e != '\n'))

		return -EINVAL;