Commit b8d0b1a4 authored Feb 17, 2020 by Dan Carpenter Committed by Greg Kroah-Hartman Mar 11, 2020

dmaengine: coh901318: Fix a double lock bug in dma_tc_handle()



commit 36d5d22090d13fd3a7a8c9663a711cbe6970aac8 upstream.

The caller is already holding the lock so this will deadlock.

Fixes: 0b58828c ("DMAENGINE: COH 901 318 remove irq counting")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20200217144050.3i4ymbytogod4ijn@kili.mountain


Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 367a1fd2

drivers/dma/coh901318.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -1944,8 +1944,6 @@ static void dma_tc_handle(struct coh901318_chan *cohc)
		return;
		}

		spin_lock(&cohc->lock);

		/*
		* When we reach this point, at least one queue item
		* should have been moved over from cohc->queue to
		@@ -1966,8 +1964,6 @@ static void dma_tc_handle(struct coh901318_chan *cohc)
		if (coh901318_queue_start(cohc) == NULL)
		cohc->busy = 0;

		spin_unlock(&cohc->lock);

		/*
		* This tasklet will remove items from cohc->active
		* and thus terminates them.