Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b801e7f8 authored by Sudeep Holla's avatar Sudeep Holla Committed by Greg Kroah-Hartman
Browse files

MIPS: ttyFDC: replace IRQF_NO_SUSPEND with IRQF_COND_SUSPEND 



Since the FD interrupt handler can discern spurious IRQs and it is
shared with timer interrupt, use IRQF_COND_SUSPEND instead of
IRQF_NO_SUSPEND.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>
Signed-off-by: default avatarSudeep Holla <sudeep.holla@arm.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 14996122

drivers/tty/mips_ejtag_fdc.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -977,7 +977,7 @@ static int mips_ejtag_fdc_tty_probe(struct mips_cdmm_device *dev) 
	/* Try requesting the IRQ */

	/* Try requesting the IRQ */

	if (priv->irq >= 0) {

	if (priv->irq >= 0) {

		/*

		/*

		 * IRQF_SHARED, IRQF_NO_SUSPEND: The FDC IRQ may be shared with

		 * IRQF_SHARED, IRQF_COND_SUSPEND: The FDC IRQ may be shared with

		 * other local interrupts such as the timer which sets

		 * other local interrupts such as the timer which sets

		 * IRQF_TIMER (including IRQF_NO_SUSPEND).

		 * IRQF_TIMER (including IRQF_NO_SUSPEND).

		 *

		 *
@@ -987,7 +987,7 @@ static int mips_ejtag_fdc_tty_probe(struct mips_cdmm_device *dev) 
		 */

		 */

		ret = devm_request_irq(priv->dev, priv->irq, mips_ejtag_fdc_isr,

		ret = devm_request_irq(priv->dev, priv->irq, mips_ejtag_fdc_isr,

				       IRQF_PERCPU | IRQF_SHARED |

				       IRQF_PERCPU | IRQF_SHARED |

				       IRQF_NO_THREAD | IRQF_NO_SUSPEND,

				       IRQF_NO_THREAD | IRQF_COND_SUSPEND,

				       priv->fdc_name, priv);

				       priv->fdc_name, priv);

		if (ret)

		if (ret)

			priv->irq = -1;

			priv->irq = -1;