Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b790cedd authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

[INET]: Avoid an integer divide in rt_garbage_collect() 



Since 'goal' is a signed int, compiler may emit an integer divide
to compute goal/2.

Using a right shift is OK here and less expensive.

Signed-off-by: default avatarEric Dumazet <dada1@cosmosbay.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9cb5734e

net/ipv4/route.c

+2 −2
Original line number Diff line number Diff line
@@ -851,14 +851,14 @@ static int rt_garbage_collect(void) 
			equilibrium = ipv4_dst_ops.gc_thresh;

		goal = atomic_read(&ipv4_dst_ops.entries) - equilibrium;

		if (goal > 0) {

			equilibrium += min_t(unsigned int, goal / 2, rt_hash_mask + 1);

			equilibrium += min_t(unsigned int, goal >> 1, rt_hash_mask + 1);

			goal = atomic_read(&ipv4_dst_ops.entries) - equilibrium;

		}

	} else {

		/* We are in dangerous area. Try to reduce cache really

		 * aggressively.

		 */

		goal = max_t(unsigned int, goal / 2, rt_hash_mask + 1);

		goal = max_t(unsigned int, goal >> 1, rt_hash_mask + 1);

		equilibrium = atomic_read(&ipv4_dst_ops.entries) - goal;

	}