Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b7195188 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

USB: serial: remove unnecessary reinitialisations of urb fields 



Remove unnecessary reinitialisations of completion and context fields of
urbs.

Compile-only tested.

Signed-off-by: default avatarJohan Hovold <jhovold@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 5833041f

drivers/usb/serial/io_ti.c

+0 −4
Original line number Diff line number Diff line
@@ -1951,7 +1951,6 @@ static int edge_open(struct tty_struct *tty, struct usb_serial_port *port) 
			status = -EINVAL;

			goto release_es_lock;

		}

		urb->complete = edge_interrupt_callback;

		urb->context = edge_serial;

		status = usb_submit_urb(urb, GFP_KERNEL);

		if (status) {
@@ -1978,7 +1977,6 @@ static int edge_open(struct tty_struct *tty, struct usb_serial_port *port) 
		goto unlink_int_urb;

	}

	edge_port->ep_read_urb_state = EDGE_READ_URB_RUNNING;

	urb->complete = edge_bulk_in_callback;

	urb->context = edge_port;

	status = usb_submit_urb(urb, GFP_KERNEL);

	if (status) {
@@ -2257,8 +2255,6 @@ static int restart_read(struct edgeport_port *edge_port) 


	if (edge_port->ep_read_urb_state == EDGE_READ_URB_STOPPED) {

		urb = edge_port->port->read_urb;

		urb->complete = edge_bulk_in_callback;

		urb->context = edge_port;

		status = usb_submit_urb(urb, GFP_ATOMIC);

	}

	edge_port->ep_read_urb_state = EDGE_READ_URB_RUNNING;

drivers/usb/serial/ti_usb_3410_5052.c

+0 −3
Original line number Diff line number Diff line
@@ -535,7 +535,6 @@ static int ti_open(struct tty_struct *tty, struct usb_serial_port *port) 
			status = -EINVAL;

			goto release_lock;

		}

		urb->complete = ti_interrupt_callback;

		urb->context = tdev;

		status = usb_submit_urb(urb, GFP_KERNEL);

		if (status) {
@@ -618,7 +617,6 @@ static int ti_open(struct tty_struct *tty, struct usb_serial_port *port) 
		goto unlink_int_urb;

	}

	tport->tp_read_urb_state = TI_READ_URB_RUNNING;

	urb->complete = ti_bulk_in_callback;

	urb->context = tport;

	status = usb_submit_urb(urb, GFP_KERNEL);

	if (status) {
@@ -1571,7 +1569,6 @@ static int ti_restart_read(struct ti_port *tport, struct tty_struct *tty) 
		tport->tp_read_urb_state = TI_READ_URB_RUNNING;

		urb = tport->tp_port->read_urb;

		spin_unlock_irqrestore(&tport->tp_lock, flags);

		urb->complete = ti_bulk_in_callback;

		urb->context = tport;

		status = usb_submit_urb(urb, GFP_KERNEL);

	} else  {