Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b717d985 authored by Rickard Strandqvist's avatar Rickard Strandqvist Committed by Benjamin Herrenschmidt
Browse files

arch: powerpc/fadump: Cleaning up inconsistent NULL checks 



Cleaning up inconsistent NULL checks.
There is otherwise a risk of a possible null pointer dereference.

Was largely found by using a static code analysis program called cppcheck.

Signed-off-by: default avatarRickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent 4750afa2

arch/powerpc/kernel/fadump.c

+5 −3
Original line number Diff line number Diff line
@@ -646,7 +646,7 @@ static int __init fadump_build_cpu_notes(const struct fadump_mem_struct *fdm) 
		}

		/* Lower 4 bytes of reg_value contains logical cpu id */

		cpu = reg_entry->reg_value & FADUMP_CPU_ID_MASK;

		if (!cpumask_test_cpu(cpu, &fdh->cpu_online_mask)) {

		if (fdh && !cpumask_test_cpu(cpu, &fdh->cpu_online_mask)) {

			SKIP_TO_NEXT_CPU(reg_entry);

			continue;

		}
@@ -663,9 +663,11 @@ static int __init fadump_build_cpu_notes(const struct fadump_mem_struct *fdm) 
	}

	fadump_final_note(note_buf);



	if (fdh) {

		pr_debug("Updating elfcore header (%llx) with cpu notes\n",

							fdh->elfcorehdr_addr);

		fadump_update_elfcore_header((char *)__va(fdh->elfcorehdr_addr));

	}

	return 0;



error_out: