Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b69259a1 authored by Takashi Iwai's avatar Takashi Iwai Committed by Greg Kroah-Hartman
Browse files

ALSA: hda - Downgrade error message for single-cmd fallback 



[ Upstream commit 475feec0c41ad71cb7d02f0310e56256606b57c5 ]

We made the error message for the CORB/RIRB communication clearer by
upgrading to dev_WARN() so that user can notice better.  But this
struck us like a boomerang: now it caught syzbot and reported back as
a fatal issue although it's not really any too serious bug that worth
for stopping the whole system.

OK, OK, let's be softy, downgrade it to the standard dev_err() again.

Fixes: dd65f7e19c69 ("ALSA: hda - Show the fatal CORB/RIRB error more clearly")
Reported-by: default avatar <syzbot+b3028ac3933f5c466389@syzkaller.appspotmail.com>
Link: https://lore.kernel.org/r/20191216151224.30013-1-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 35df5170

sound/pci/hda/hda_controller.c

+1 −1
Original line number Diff line number Diff line
@@ -872,7 +872,7 @@ static int azx_rirb_get_response(struct hdac_bus *bus, unsigned int addr, 
		return -EAGAIN; /* give a chance to retry */

	}



	dev_WARN(chip->card->dev,

	dev_err(chip->card->dev,

		"azx_get_response timeout, switching to single_cmd mode: last cmd=0x%08x\n",

		bus->last_cmd[addr]);

	chip->single_cmd = 1;