Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b598b670 authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

checkpatch: add 'Prefer ARRAY_SIZE" test 



Add a test for sizeof(foo)/sizeof(foo[0]) that could be ARRAY_SIZE(foo).

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 6d07d01b

scripts/checkpatch.pl

+13 −0
Original line number Diff line number Diff line
@@ -3227,6 +3227,19 @@ sub process { 
				$herecurr);

               }



# check for sizeof(foo)/sizeof(foo[0]) that could be ARRAY_SIZE(foo)

		if ($line =~ m@\bsizeof\s*\(\s*($Lval)\s*\)@) {

			my $array = $1;

			if ($line =~ m@\b(sizeof\s*\(\s*\Q$array\E\s*\)\s*/\s*sizeof\s*\(\s*\Q$array\E\s*\[\s*0\s*\]\s*\))@) {

				my $array_div = $1;

				if (WARN("ARRAY_SIZE",

					 "Prefer ARRAY_SIZE($array)\n" . $herecurr) &&

				    $fix) {

					$fixed[$fixlinenr] =~ s/\Q$array_div\E/ARRAY_SIZE($array)/;

				}

			}

		}



# check for function declarations without arguments like "int foo()"

		if ($line =~ /(\b$Type\s+$Ident)\s*\(\s*\)/) {

			if (ERROR("FUNCTION_WITHOUT_ARGS",