Commit b4fbbb75 authored Nov 11, 2020 by Dmitry Torokhov Committed by Greg Kroah-Hartman Dec 29, 2020

Input: ads7846 - fix unaligned access on 7845



[ Upstream commit 03e2c9c782f721b661a0e42b1b58f394b5298544 ]

req->sample[1] is not naturally aligned at word boundary, and therefore we
should use get_unaligned_be16() when accessing it.

Fixes: 3eac5c7e ("Input: ads7846 - extend the driver for ads7845 controller support")
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 4ea501f3

drivers/input/touchscreen/ads7846.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -35,6 +35,7 @@
		#include <linux/regulator/consumer.h>
		#include <linux/module.h>
		#include <asm/irq.h>
		#include <asm/unaligned.h>

		/*
		* This code has been heavily tested on a Nokia 770, and lightly
		@@ -410,7 +411,7 @@ static int ads7845_read12_ser(struct device *dev, unsigned command)

		if (status == 0) {
		/* BE12 value, then padding */
		status = be16_to_cpu(((u16 )&req->sample[1]));
		status = get_unaligned_be16(&req->sample[1]);
		status = status >> 3;
		status &= 0x0fff;
		}