Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b4f1b67b authored by Roel Kluin's avatar Roel Kluin Committed by Jason Wessel
Browse files

kgdbts: Read buffer overflow 



Prevent write to put_buf[BUFMAX] in kgdb test suite.

If put_buf_cnt was BUFMAX - 1 at the earlier test,
`\0' is written to put_buf[BUFMAX].

Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
Signed-off-by: default avatarJason Wessel <jason.wessel@windriver.com>
parent 84667d48

drivers/misc/kgdbts.c

+6 −0
Original line number Diff line number Diff line
@@ -712,6 +712,12 @@ static int run_simple_test(int is_get_char, int chr) 


	/* End of packet == #XX so look for the '#' */

	if (put_buf_cnt > 3 && put_buf[put_buf_cnt - 3] == '#') {

		if (put_buf_cnt >= BUFMAX) {

			eprintk("kgdbts: ERROR: put buffer overflow on"

				" '%s' line %i\n", ts.name, ts.idx);

			put_buf_cnt = 0;

			return 0;

		}

		put_buf[put_buf_cnt] = '\0';

		v2printk("put%i: %s\n", ts.idx, put_buf);

		/* Trigger check here */