Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b4ecc15d authored by Jonathan Liu's avatar Jonathan Liu Committed by Greg Kroah-Hartman
Browse files

usb: musb: sunxi: Explicitly release USB PHY on exit 



commit 6ed05c68cbcae42cd52b8e53b66952bfa9c002ce upstream.

This fixes a kernel oops when unloading the driver due to usb_put_phy
being called after usb_phy_generic_unregister when the device is
detached. Calling usb_phy_generic_unregister causes x->dev->driver to
be NULL in usb_put_phy and results in a NULL pointer dereference.

Signed-off-by: default avatarJonathan Liu <net147@gmail.com>
Signed-off-by: default avatarBin Liu <b-liu@ti.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 09fad6f2

drivers/usb/musb/sunxi.c

+2 −0
Original line number Diff line number Diff line
@@ -313,6 +313,8 @@ static int sunxi_musb_exit(struct musb *musb) 
	if (test_bit(SUNXI_MUSB_FL_HAS_SRAM, &glue->flags))

		sunxi_sram_release(musb->controller->parent);



	devm_usb_put_phy(glue->dev, glue->xceiv);



	return 0;

}