Commit b4966b77 authored Mar 09, 2011 by Daniel J Blueman Committed by Chris Mason Mar 10, 2011

btrfs: fix dip leak



The btrfs DIO code leaks dip structs when dip->csums allocation
fails; bio->bi_end_io isn't set at the point where the free_ordered
branch is consequently taken, thus bio_endio doesn't call the function
which would free it in the normal case. Fix.

Signed-off-by: Daniel J Blueman <daniel.blueman@gmail.com>
Acked-by: Miao Xie <miaox@cn.fujitsu.com>
Signed-off-by: Chris Mason <chris.mason@oracle.com>

parent ea8efc74

fs/btrfs/inode.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -6058,6 +6058,7 @@ static void btrfs_submit_direct(int rw, struct bio bio, struct inode inode,
		if (!skip_sum) {
		dip->csums = kmalloc(sizeof(u32) * bio->bi_vcnt, GFP_NOFS);
		if (!dip->csums) {
		kfree(dip);
		ret = -ENOMEM;
		goto free_ordered;
		}