Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b3f639c4 authored by Ben Dooks's avatar Ben Dooks Committed by Kukjin Kim
Browse files

ARM: S3C64XX: Fix keypad setup to configure correct number of rows 



The call to s3c_gpio_cfgrange_nopull() takes a size and base
but this looks like it is trying to do base and end. This means
it is configuring too many GPIOs and on the case of the Cragganmore
means we're seeing an overflow of the ROW pins causing problems
with the keyboard driver.

Signed-off-by: default avatarBen Dooks <ben-linux@fluff.org>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: default avatarKukjin Kim <kgene.kim@samsung.com>
parent 6a53048d

arch/arm/mach-s3c64xx/setup-keypad.c

+1 −1
Original line number Diff line number Diff line
@@ -17,7 +17,7 @@ 
void samsung_keypad_cfg_gpio(unsigned int rows, unsigned int cols)

{

	/* Set all the necessary GPK pins to special-function 3: KP_ROW[x] */

	s3c_gpio_cfgrange_nopull(S3C64XX_GPK(8), 8 + rows, S3C_GPIO_SFN(3));

	s3c_gpio_cfgrange_nopull(S3C64XX_GPK(8), rows, S3C_GPIO_SFN(3));



	/* Set all the necessary GPL pins to special-function 3: KP_COL[x] */

	s3c_gpio_cfgrange_nopull(S3C64XX_GPL(0), cols, S3C_GPIO_SFN(3));