Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b3a084b9 authored Sep 22, 2010 by Eric Dumazet Committed by Paul E. McKenney Sep 23, 2010

rcu: rcu_read_lock_bh_held(): disabling irqs also disables bh



rcu_dereference_bh() doesnt know yet about hard irq being disabled, so
lockdep can trigger in netpoll_rx() after commit f0f9deae (netpoll:
Disable IRQ around RCU dereference in netpoll_rx)

Reported-by: Miles Lane <miles.lane@gmail.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Tested-by: Miles Lane <miles.lane@gmail.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

parent 27c379f7

include/linux/rcupdate.h

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -454,7 +454,7 @@ static inline notrace void rcu_read_unlock_sched_notrace(void)
	* Makes rcu_dereference_check() do the dirty work.		* Makes rcu_dereference_check() do the dirty work.
	*/		*/
	#define rcu_dereference_bh(p) \		#define rcu_dereference_bh(p) \
	rcu_dereference_check(p, rcu_read_lock_bh_held())		rcu_dereference_check(p, rcu_read_lock_bh_held() \|\| irqs_disabled())

	/**		/**
	* rcu_dereference_sched - fetch RCU-protected pointer, checking for RCU-sched		* rcu_dereference_sched - fetch RCU-protected pointer, checking for RCU-sched