Commit b392c64f authored Apr 16, 2015 by Joe Perches Committed by Linus Torvalds Apr 17, 2015

checkpatch: match more world writable permissions



Currently checkpatch will fuss if one uses world writable settings in
debugfs files and DEVICE_ATTR uses by testing S_IWUGO but not testing
S_IWOTH, S_IRWXUGO or S_IALLUGO.

Extend the check to catch all cases exporting world writable permissions
including octal values.

[akpm@linux-foundation.org: remove stray $]
Signed-off-by: Joe Perches <joe@perches.com>
Original-patch-by: Nicholas Mc Guire <hofrat@osadl.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent ebfd7d62

scripts/checkpatch.pl

+10 −2

Original line number	Diff line number	Diff line
		@@ -443,6 +443,14 @@ foreach my $entry (@mode_permission_funcs) {
		$mode_perms_search .= $entry->[0];
		}

		our $mode_perms_world_writable = qr{
		S_IWUGO \|
		S_IWOTH \|
		S_IRWXUGO \|
		S_IALLUGO \|
		0[0-7][0-7][2367]
		}x;

		our $allowed_asm_includes = qr{(?x:
		irq\|
		memory\|
		@@ -5356,8 +5364,8 @@ sub process {
		}
		}

		if ($line =~ /debugfs_create_file.*S_IWUGO/ \|\|
		$line =~ /DEVICE_ATTR.*S_IWUGO/ ) {
		if ($line =~ /debugfs_create_\w+.*\b$mode_perms_world_writable\b/ \|\|
		$line =~ /DEVICE_ATTR.*\b$mode_perms_world_writable\b/) {
		WARN("EXPORTED_WORLD_WRITABLE",
		"Exporting world writable files is usually an error. Consider more restrictive permissions.\n" . $herecurr);
		}