Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b318d268 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

staging: rtl8188eu: prevent ->ssid overflow in rtw_wx_set_scan() 



commit 74b6b20df8cfe90ada777d621b54c32e69e27cd7 upstream.

This code has a check to prevent read overflow but it needs another
check to prevent writing beyond the end of the ->ssid[] array.

Fixes: a2c60d42 ("staging: r8188eu: Add files for new driver - part 16")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/YEHymwsnHewzoam7@mwanda


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9705bfef

drivers/staging/rtl8188eu/os_dep/ioctl_linux.c

+4 −2
Original line number Diff line number Diff line
@@ -1172,9 +1172,11 @@ static int rtw_wx_set_scan(struct net_device *dev, struct iw_request_info *a, 
						break;

					}

					sec_len = *(pos++); len -= 1;

					if (sec_len > 0 && sec_len <= len) {

					if (sec_len > 0 &&

					    sec_len <= len &&

					    sec_len <= 32) {

						ssid[ssid_index].SsidLength = sec_len;

						memcpy(ssid[ssid_index].Ssid, pos, ssid[ssid_index].SsidLength);

						memcpy(ssid[ssid_index].Ssid, pos, sec_len);

						ssid_index++;

					}

					pos += sec_len;