Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b314fc77 authored by Fabio Estevam's avatar Fabio Estevam Committed by Tejun Heo
Browse files

pata_imx: Use devm_ioremap_resource() to simplify code 



Using devm_ioremap_resource() can lead to code simplication, as we don't need
to explicitily check for error returned by platform_get_resource().

Also, no need to print an error message when devm_ioremap_resource() fails,
as the OOM code code will shout loudly on such condition.

Signed-off-by: default avatarFabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 1bc18086

drivers/ata/pata_imx.c

+2 −7
Original line number Diff line number Diff line
@@ -99,10 +99,6 @@ static int pata_imx_probe(struct platform_device *pdev) 
	struct resource *io_res;

	int ret;



	io_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	if (io_res == NULL)

		return -EINVAL;



	irq = platform_get_irq(pdev, 0);

	if (irq <= 0)

		return -EINVAL;
@@ -133,10 +129,9 @@ static int pata_imx_probe(struct platform_device *pdev) 
	ap->pio_mask = ATA_PIO0;

	ap->flags |= ATA_FLAG_SLAVE_POSS;



	priv->host_regs = devm_ioremap(&pdev->dev, io_res->start,

		resource_size(io_res));

	io_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	priv->host_regs = devm_ioremap_resource(&pdev->dev, io_res);

	if (!priv->host_regs) {

		dev_err(&pdev->dev, "failed to map IO/CTL base\n");

		ret = -EBUSY;

		goto err;

	}