Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b2262df7 authored by Simon Wunderlich's avatar Simon Wunderlich Committed by Antonio Quartulli
Browse files

batman-adv: fix potential orig_node reference leak 



Since batadv_orig_node_new() sets the refcount to two, assuming that
the calling function will use a reference for putting the orig_node into
a hash or similar, both references must be freed if initialization of
the orig_node fails. Otherwise that object may be leaked in that error
case.

Reported-by: default avatarAntonio Quartulli <antonio@meshcoding.com>
Signed-off-by: default avatarSimon Wunderlich <sw@simonwunderlich.de>
Signed-off-by: default avatarMarek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: default avatarAntonio Quartulli <antonio@meshcoding.com>
parent 08bf0ed2

net/batman-adv/bat_iv_ogm.c

+2 −0
Original line number Diff line number Diff line
@@ -254,6 +254,8 @@ batadv_iv_ogm_orig_get(struct batadv_priv *bat_priv, const uint8_t *addr) 
free_bcast_own:

	kfree(orig_node->bat_iv.bcast_own);

free_orig_node:

	/* free twice, as batadv_orig_node_new sets refcount to 2 */

	batadv_orig_node_free_ref(orig_node);

	batadv_orig_node_free_ref(orig_node);



	return NULL;