Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b1a2348a authored by Brian Norris's avatar Brian Norris
Browse files

mtd: nand: fixup bounds checks for nand_{lock,unlock}() 



Coverity noticed that these 'ret' assignments weren't being used. Let's
use them.

Note that nand_lock() and nand_unlock() are still not officially used by
any drivers.

Coverity CIDs #1227054 and #1227037

Signed-off-by: default avatarBrian Norris <computersforpeace@gmail.com>
parent b9da8bae

drivers/mtd/nand/nand_base.c

+2 −2
Original line number Diff line number Diff line
@@ -968,7 +968,7 @@ int nand_unlock(struct mtd_info *mtd, loff_t ofs, uint64_t len) 
			__func__, (unsigned long long)ofs, len);



	if (check_offs_len(mtd, ofs, len))

		ret = -EINVAL;

		return -EINVAL;



	/* Align to last block address if size addresses end of the device */

	if (ofs + len == mtd->size)
@@ -1031,7 +1031,7 @@ int nand_lock(struct mtd_info *mtd, loff_t ofs, uint64_t len) 
			__func__, (unsigned long long)ofs, len);



	if (check_offs_len(mtd, ofs, len))

		ret = -EINVAL;

		return -EINVAL;



	nand_get_device(mtd, FL_LOCKING);