Commit b0edba7e authored Mar 28, 2009 by Uwe Kleine-König Committed by Richard Purdie Apr 06, 2009

leds: move h1940-leds's probe function to .devinit.text



A pointer to h1940leds_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded.  Otherwise (if also having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.

An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Richard Purdie <rpurdie@linux.intel.com>

parent bfb2cc48

drivers/leds/leds-h1940.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -104,7 +104,7 @@ static struct led_classdev h1940_blueled = {
		.default_trigger = "h1940-bluetooth",
		};

		static int __init h1940leds_probe(struct platform_device *pdev)
		static int __devinit h1940leds_probe(struct platform_device *pdev)
		{
		int ret;