Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit af1ac18a authored by Dan Carpenter's avatar Dan Carpenter Committed by Ben Skeggs
Browse files

drm/nouveau/disp: sizeof() wrong pointer 



"data" is a void pointer and "args" is "data" after we have casted it to
a struct.  We care about the size of the struct here.  Btw,
sizeof(*data) is 1.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMarcin Slusarz <marcin.slusarz@gmail.com>
Signed-off-by: default avatarBen Skeggs <bskeggs@redhat.com>
parent 264ce192

drivers/gpu/drm/nouveau/core/engine/disp/nv50.c

+2 −2
Original line number Diff line number Diff line
@@ -333,7 +333,7 @@ nv50_disp_sync_ctor(struct nouveau_object *parent, 
	struct nv50_disp_dmac *dmac;

	int ret;



	if (size < sizeof(*data) || args->head > 1)

	if (size < sizeof(*args) || args->head > 1)

		return -EINVAL;



	ret = nv50_disp_dmac_create_(parent, engine, oclass, args->pushbuf,
@@ -372,7 +372,7 @@ nv50_disp_ovly_ctor(struct nouveau_object *parent, 
	struct nv50_disp_dmac *dmac;

	int ret;



	if (size < sizeof(*data) || args->head > 1)

	if (size < sizeof(*args) || args->head > 1)

		return -EINVAL;



	ret = nv50_disp_dmac_create_(parent, engine, oclass, args->pushbuf,

drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c

+2 −2
Original line number Diff line number Diff line
@@ -228,7 +228,7 @@ nvd0_disp_sync_ctor(struct nouveau_object *parent, 
	struct nv50_disp_dmac *dmac;

	int ret;



	if (size < sizeof(*data) || args->head >= priv->head.nr)

	if (size < sizeof(*args) || args->head >= priv->head.nr)

		return -EINVAL;



	ret = nv50_disp_dmac_create_(parent, engine, oclass, args->pushbuf,
@@ -268,7 +268,7 @@ nvd0_disp_ovly_ctor(struct nouveau_object *parent, 
	struct nv50_disp_dmac *dmac;

	int ret;



	if (size < sizeof(*data) || args->head >= priv->head.nr)

	if (size < sizeof(*args) || args->head >= priv->head.nr)

		return -EINVAL;



	ret = nv50_disp_dmac_create_(parent, engine, oclass, args->pushbuf,