Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ae6ee2fd authored by James Hogan's avatar James Hogan Committed by Wim Van Sebroeck
Browse files

watchdog: imgpdc: Fix default heartbeat 



The IMG PDC watchdog driver heartbeat module parameter has no default so
it is initialised to zero. This results in the following warning during
probe:

imgpdc-wdt 2006000.wdt: Initial timeout out of range! setting max timeout

The module parameter description implies that the default value should
be PDC_WDT_DEF_TIMEOUT, which isn't yet used, so initialise it to that.

Also tweak the heartbeat module parameter description for consistency.

Fixes: 93937669 ("watchdog: ImgTec PDC Watchdog Timer Driver")
Signed-off-by: default avatarJames Hogan <james.hogan@imgtec.com>
Cc: Ezequiel Garcia <ezequiel.garcia@imgtec.com>
Cc: Naidu Tellapati <Naidu.Tellapati@imgtec.com>
Cc: Jude Abraham <Jude.Abraham@imgtec.com>
Cc: linux-watchdog@vger.kernel.org
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
parent a629c08f

drivers/watchdog/imgpdc_wdt.c

+3 −3
Original line number Diff line number Diff line
@@ -42,9 +42,9 @@ 
#define PDC_WDT_MIN_TIMEOUT		1

#define PDC_WDT_DEF_TIMEOUT		64



static int heartbeat;

static int heartbeat = PDC_WDT_DEF_TIMEOUT;

module_param(heartbeat, int, 0);

MODULE_PARM_DESC(heartbeat, "Watchdog heartbeats in seconds. "

MODULE_PARM_DESC(heartbeat, "Watchdog heartbeats in seconds "

	"(default=" __MODULE_STRING(PDC_WDT_DEF_TIMEOUT) ")");



static bool nowayout = WATCHDOG_NOWAYOUT;