Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ae6c8e83 authored by Sreelakshmi Gownipalli's avatar Sreelakshmi Gownipalli Committed by Chris Lew
Browse files

diag: Change to GFP_KERNEL in diagfwd_buffers_init() 



In diagfwd_buffers_init() change the memory allocation to
from GFP_ATOMIC to GFP_KERNEL.
This patch also replaces spinlock with mutex to enable device
to go into sleep mode.

Change-Id: I8ea299a4287401a0a01ff7bbdd86c37ccd138480
Signed-off-by: default avatarSreelakshmi Gownipalli <sgownipa@codeaurora.org>
parent 73af8982

drivers/char/diag/diagfwd_peripheral.c

+15 −17
Original line number Diff line number Diff line
@@ -436,9 +436,9 @@ int diagfwd_peripheral_init(void) 
			fwd_info->inited = 1;

			fwd_info->read_bytes = 0;

			fwd_info->write_bytes = 0;

			spin_lock_init(&fwd_info->buf_lock);

			spin_lock_init(&fwd_info->write_buf_lock);

			mutex_init(&fwd_info->buf_mutex);

			mutex_init(&fwd_info->data_mutex);

			spin_lock_init(&fwd_info->write_buf_lock);

		}

	}
@@ -452,8 +452,8 @@ int diagfwd_peripheral_init(void) 
			fwd_info->ch_open = 0;

			fwd_info->read_bytes = 0;

			fwd_info->write_bytes = 0;

			spin_lock_init(&fwd_info->buf_lock);

			spin_lock_init(&fwd_info->write_buf_lock);

			mutex_init(&fwd_info->buf_mutex);

			mutex_init(&fwd_info->data_mutex);

			/*

			 * This state shouldn't be set for Control channels
@@ -1065,7 +1065,6 @@ static void diagfwd_queue_read(struct diagfwd_info *fwd_info) 


void diagfwd_buffers_init(struct diagfwd_info *fwd_info)

{

	unsigned long flags;



	if (!fwd_info)

		return;
@@ -1076,10 +1075,10 @@ void diagfwd_buffers_init(struct diagfwd_info *fwd_info) 
		return;

	}



	spin_lock_irqsave(&fwd_info->buf_lock, flags);

	mutex_lock(&fwd_info->buf_mutex);

	if (!fwd_info->buf_1) {

		fwd_info->buf_1 = kzalloc(sizeof(struct diagfwd_buf_t),

					  GFP_ATOMIC);

					  GFP_KERNEL);

		if (!fwd_info->buf_1)

			goto err;

		kmemleak_not_leak(fwd_info->buf_1);
@@ -1087,7 +1086,7 @@ void diagfwd_buffers_init(struct diagfwd_info *fwd_info) 
	if (!fwd_info->buf_1->data) {

		fwd_info->buf_1->data = kzalloc(PERIPHERAL_BUF_SZ +

					APF_DIAG_PADDING,

					GFP_ATOMIC);

					GFP_KERNEL);

		if (!fwd_info->buf_1->data)

			goto err;

		fwd_info->buf_1->len = PERIPHERAL_BUF_SZ;
@@ -1099,7 +1098,7 @@ void diagfwd_buffers_init(struct diagfwd_info *fwd_info) 
	if (fwd_info->type == TYPE_DATA) {

		if (!fwd_info->buf_2) {

			fwd_info->buf_2 = kzalloc(sizeof(struct diagfwd_buf_t),

					      GFP_ATOMIC);

					      GFP_KERNEL);

			if (!fwd_info->buf_2)

				goto err;

			kmemleak_not_leak(fwd_info->buf_2);
@@ -1108,7 +1107,7 @@ void diagfwd_buffers_init(struct diagfwd_info *fwd_info) 
		if (!fwd_info->buf_2->data) {

			fwd_info->buf_2->data = kzalloc(PERIPHERAL_BUF_SZ +

							APF_DIAG_PADDING,

						    GFP_ATOMIC);

						    GFP_KERNEL);

			if (!fwd_info->buf_2->data)

				goto err;

			fwd_info->buf_2->len = PERIPHERAL_BUF_SZ;
@@ -1124,7 +1123,7 @@ void diagfwd_buffers_init(struct diagfwd_info *fwd_info) 
				fwd_info->buf_1->data_raw =

					kzalloc(PERIPHERAL_BUF_SZ +

						APF_DIAG_PADDING,

						GFP_ATOMIC);

						GFP_KERNEL);

				if (!fwd_info->buf_1->data_raw)

					goto err;

				fwd_info->buf_1->len_raw = PERIPHERAL_BUF_SZ;
@@ -1134,7 +1133,7 @@ void diagfwd_buffers_init(struct diagfwd_info *fwd_info) 
				fwd_info->buf_2->data_raw =

					kzalloc(PERIPHERAL_BUF_SZ +

						APF_DIAG_PADDING,

						GFP_ATOMIC);

						GFP_KERNEL);

				if (!fwd_info->buf_2->data_raw)

					goto err;

				fwd_info->buf_2->len_raw = PERIPHERAL_BUF_SZ;
@@ -1148,7 +1147,7 @@ void diagfwd_buffers_init(struct diagfwd_info *fwd_info) 
		if (!fwd_info->buf_1->data_raw) {

			fwd_info->buf_1->data_raw = kzalloc(PERIPHERAL_BUF_SZ +

						APF_DIAG_PADDING,

							GFP_ATOMIC);

							GFP_KERNEL);

			if (!fwd_info->buf_1->data_raw)

				goto err;

			fwd_info->buf_1->len_raw = PERIPHERAL_BUF_SZ;
@@ -1156,22 +1155,21 @@ void diagfwd_buffers_init(struct diagfwd_info *fwd_info) 
		}

	}



	spin_unlock_irqrestore(&fwd_info->buf_lock, flags);

	mutex_unlock(&fwd_info->buf_mutex);

	return;



err:

	spin_unlock_irqrestore(&fwd_info->buf_lock, flags);

	mutex_unlock(&fwd_info->buf_mutex);

	diagfwd_buffers_exit(fwd_info);

}



static void diagfwd_buffers_exit(struct diagfwd_info *fwd_info)

{

	unsigned long flags;



	if (!fwd_info)

		return;



	spin_lock_irqsave(&fwd_info->buf_lock, flags);

	mutex_lock(&fwd_info->buf_mutex);

	if (fwd_info->buf_1) {

		kfree(fwd_info->buf_1->data);

		fwd_info->buf_1->data = NULL;
@@ -1188,7 +1186,7 @@ static void diagfwd_buffers_exit(struct diagfwd_info *fwd_info) 
		kfree(fwd_info->buf_2);

		fwd_info->buf_2 = NULL;

	}

	spin_unlock_irqrestore(&fwd_info->buf_lock, flags);

	mutex_unlock(&fwd_info->buf_mutex);

}



void diagfwd_write_buffers_init(struct diagfwd_info *fwd_info)

drivers/char/diag/diagfwd_peripheral.h

+1 −1
Original line number Diff line number Diff line
@@ -71,8 +71,8 @@ struct diagfwd_info { 
	atomic_t opened;

	unsigned long read_bytes;

	unsigned long write_bytes;

	spinlock_t buf_lock;

	spinlock_t write_buf_lock;

	struct mutex buf_mutex;

	struct mutex data_mutex;

	void *ctxt;

	struct diagfwd_buf_t *buf_1;

drivers/char/diag/diagfwd_socket.c

+3 −7
Original line number Diff line number Diff line
@@ -287,13 +287,6 @@ static void socket_data_ready(struct sock *sk_ptr) 
	spin_unlock_irqrestore(&info->lock, flags);

	diag_ws_on_notify();



	/*

	 * Initialize read buffers for the servers. The servers must read data

	 * first to get the address of its clients.

	 */

	if (!atomic_read(&info->opened) && info->port_type == PORT_TYPE_SERVER)

		diagfwd_buffers_init(info->fwd_ctxt);



	queue_work(info->wq, &(info->read_work));

	wake_up_interruptible(&info->read_wait_q);

}
@@ -679,6 +672,9 @@ static void socket_read_work_fn(struct work_struct *work) 
	if (!info)

		return;



	if (!atomic_read(&info->opened) && info->port_type == PORT_TYPE_SERVER)

		diagfwd_buffers_init(info->fwd_ctxt);



	diagfwd_channel_read(info->fwd_ctxt);

}