Commit adf044c8 authored Aug 03, 2008 by Sven Wegener Committed by David S. Miller Aug 03, 2008

net: Add missing extra2 parameter for ip_default_ttl sysctl



Commit 76e6ebfb ("netns: add namespace
parameter to rt_cache_flush") acceses the extra2 parameter of the
ip_default_ttl ctl_table, but it is never set to a meaningful
value. When e84f84f2 ("netns: place
rt_genid into struct net") is applied, we'll oops in
rt_cache_invalidate(). Set extra2 to init_net, to avoid that.

Reported-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Signed-off-by: Sven Wegener <sven.wegener@stealer.net>
Tested-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Acked-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent e5a4a72d

net/ipv4/sysctl_net_ipv4.c

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -232,6 +232,7 @@ static struct ctl_table ipv4_table[] = {
	.mode = 0644,		.mode = 0644,
	.proc_handler = &ipv4_doint_and_flush,		.proc_handler = &ipv4_doint_and_flush,
	.strategy = &ipv4_doint_and_flush_strategy,		.strategy = &ipv4_doint_and_flush_strategy,
			.extra2 = &init_net,
	},		},
	{		{
	.ctl_name = NET_IPV4_NO_PMTU_DISC,		.ctl_name = NET_IPV4_NO_PMTU_DISC,