Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ad673282 authored by Jörn Engel's avatar Jörn Engel Committed by Nicholas Bellinger
Browse files

target: Change default sense key of NOT_READY 



As the comment sais, this allows Solaris initiators to survive
intermittent errors.  The comment from someone reading the Solaris
sources seem to imply that multipathing would be broken without this
patch as well.

Signed-off-by: default avatarJoern Engel <joern@logfs.org>
Cc: Brian Bunker <brian@purestorage.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 0463a3fe

drivers/target/target_core_transport.c

+7 −2
Original line number Diff line number Diff line
@@ -2765,8 +2765,13 @@ transport_send_check_condition_and_sense(struct se_cmd *cmd, 
		/* CURRENT ERROR */

		buffer[0] = 0x70;

		buffer[SPC_ADD_SENSE_LEN_OFFSET] = 10;

		/* ILLEGAL REQUEST */

		buffer[SPC_SENSE_KEY_OFFSET] = ILLEGAL_REQUEST;

		/*

		 * Returning ILLEGAL REQUEST would cause immediate IO errors on

		 * Solaris initiators.  Returning NOT READY instead means the

		 * operations will be retried a finite number of times and we

		 * can survive intermittent errors.

		 */

		buffer[SPC_SENSE_KEY_OFFSET] = NOT_READY;

		/* LOGICAL UNIT COMMUNICATION FAILURE */

		buffer[SPC_ASC_KEY_OFFSET] = 0x08;

		break;