Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit aceb5d20 authored by Subhransu S. Prusty's avatar Subhransu S. Prusty Committed by Mark Brown
Browse files

ASoC: Intel: Skylake: Fix possible memory corruption in codec dai dma params 



Set required parameters for hdac_ext_dma_params object instead of
skl_dma_params.

Signed-off-by: default avatarSubhransu S. Prusty <subhransu.s.prusty@intel.com>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 4b235c43

sound/soc/intel/skylake/skl-pcm.c

+2 −4
Original line number Diff line number Diff line
@@ -475,7 +475,7 @@ static int skl_link_hw_params(struct snd_pcm_substream *substream, 
	struct hdac_ext_bus *ebus = dev_get_drvdata(dai->dev);

	struct hdac_ext_stream *link_dev;

	struct snd_soc_pcm_runtime *rtd = snd_pcm_substream_chip(substream);

	struct skl_dma_params *dma_params;

	struct hdac_ext_dma_params *dma_params;

	struct snd_soc_dai *codec_dai = rtd->codec_dai;

	struct skl_pipe_params p_params = {0};
@@ -487,11 +487,9 @@ static int skl_link_hw_params(struct snd_pcm_substream *substream, 
	snd_soc_dai_set_dma_data(dai, substream, (void *)link_dev);



	/* set the stream tag in the codec dai dma params  */

	dma_params = (struct skl_dma_params *)

			snd_soc_dai_get_dma_data(codec_dai, substream);

	dma_params = snd_soc_dai_get_dma_data(codec_dai, substream);

	if (dma_params)

		dma_params->stream_tag =  hdac_stream(link_dev)->stream_tag;

	snd_soc_dai_set_dma_data(codec_dai, substream, (void *)dma_params);



	p_params.s_fmt = snd_pcm_format_width(params_format(params));

	p_params.ch = params_channels(params);