Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit accaed26 authored by Jiri Olsa's avatar Jiri Olsa Committed by Arnaldo Carvalho de Melo
Browse files

perf tools: Make is_printable_array global 



It's used from 2 objects in perf, so it's better to keep just one copy.

Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Pirko <jiri@mellanox.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/1468685480-18951-3-git-send-email-jolsa@kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 249de6e0

tools/perf/util/python.c

+0 −12
Original line number Diff line number Diff line
@@ -295,18 +295,6 @@ static bool is_tracepoint(struct pyrf_event *pevent) 
	return pevent->evsel->attr.type == PERF_TYPE_TRACEPOINT;

}



static int is_printable_array(char *p, unsigned int len)

{

	unsigned int i;



	for (i = 0; i < len; i++) {

		if (!isprint(p[i]) && !isspace(p[i]))

			return 0;

	}



	return 1;

}



static PyObject*

tracepoint_field(struct pyrf_event *pe, struct format_field *field)

{

tools/perf/util/scripting-engines/trace-event-python.c

+0 −16
Original line number Diff line number Diff line
@@ -386,22 +386,6 @@ static PyObject *python_process_callchain(struct perf_sample *sample, 
	return pylist;

}



static int is_printable_array(char *p, unsigned int len)

{

	unsigned int i;



	if (!p || !len || p[len - 1] != 0)

		return 0;



	len--;



	for (i = 0; i < len; i++) {

		if (!isprint(p[i]) && !isspace(p[i]))

			return 0;

	}

	return 1;

}



static void python_process_tracepoint(struct perf_sample *sample,

				      struct perf_evsel *evsel,

				      struct addr_location *al)

tools/perf/util/util.c

+16 −0
Original line number Diff line number Diff line
@@ -746,3 +746,19 @@ void print_binary(unsigned char *data, size_t len, 
	}

	printer(BINARY_PRINT_DATA_END, -1, extra);

}



int is_printable_array(char *p, unsigned int len)

{

	unsigned int i;



	if (!p || !len || p[len - 1] != 0)

		return 0;



	len--;



	for (i = 0; i < len; i++) {

		if (!isprint(p[i]) && !isspace(p[i]))

			return 0;

	}

	return 1;

}

tools/perf/util/util.h

+1 −0
Original line number Diff line number Diff line
@@ -364,4 +364,5 @@ void print_binary(unsigned char *data, size_t len, 
extern int sched_getcpu(void);

#endif



int is_printable_array(char *p, unsigned int len);

#endif /* GIT_COMPAT_UTIL_H */