Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit abf9767c authored Jan 11, 2014 by Christian Engelmayer Committed by Steve French Jan 19, 2014

cifs: Fix memory leak in cifs_hardlink()



Fix a potential memory leak in the cifs_hardlink() error handling path.
Detected by Coverity: CID 728510, CID 728511.

Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Signed-off-by: Steve French <smfrench@gmail.com>

parent d8ec26d7

fs/cifs/link.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -438,8 +438,10 @@ cifs_hardlink(struct dentry old_file, struct inode inode,
		CIFS_MOUNT_MAP_SPECIAL_CHR);
		else {
		server = tcon->ses->server;
		if (!server->ops->create_hardlink)
		return -ENOSYS;
		if (!server->ops->create_hardlink) {
		rc = -ENOSYS;
		goto cifs_hl_exit;
		}
		rc = server->ops->create_hardlink(xid, tcon, from_name, to_name,
		cifs_sb);
		if ((rc == -EIO) \|\| (rc == -EINVAL))