Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ab7e23f3 authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

checkpatch: add test for repeated const uses 



Using 'const <type> const *' is generally meant to be written 'const
<type> * const'.

Add a test for the miswritten form.

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent f34e4a4f

scripts/checkpatch.pl

+18 −0
Original line number Diff line number Diff line
@@ -323,6 +323,7 @@ our $Operators = qr{ 


our $c90_Keywords = qr{do|for|while|if|else|return|goto|continue|switch|default|case|break}x;



our $BasicType;

our $NonptrType;

our $NonptrTypeMisordered;

our $NonptrTypeWithAttr;
@@ -514,6 +515,11 @@ sub build_types { 
	my $Misordered = "(?x:  \n" . join("|\n  ", @typeListMisordered) . "\n)";

	my $allWithAttr = "(?x:  \n" . join("|\n  ", @typeListWithAttr) . "\n)";

	$Modifier	= qr{(?:$Attribute|$Sparse|$mods)};

	$BasicType	= qr{

				(?:$typeOtherOSTypedefs\b)|

				(?:$typeTypedefs\b)|

				(?:${all}\b)

		}x;

	$NonptrType	= qr{

			(?:$Modifier\s+|const\s+)*

			(?:
@@ -3192,6 +3198,18 @@ sub process { 
				$herecurr);

               }



# check for const <foo> const where <foo> is not a pointer or array type

		if ($sline =~ /\bconst\s+($BasicType)\s+const\b/) {

			my $found = $1;

			if ($sline =~ /\bconst\s+\Q$found\E\s+const\b\s*\*/) {

				WARN("CONST_CONST",

				     "'const $found const *' should probably be 'const $found * const'\n" . $herecurr);

			} elsif ($sline !~ /\bconst\s+\Q$found\E\s+const\s+\w+\s*\[/) {

				WARN("CONST_CONST",

				     "'const $found const' should probably be 'const $found'\n" . $herecurr);

			}

		}



# check for non-global char *foo[] = {"bar", ...} declarations.

		if ($line =~ /^.\s+(?:static\s+|const\s+)?char\s+\*\s*\w+\s*\[\s*\]\s*=\s*\{/) {

			WARN("STATIC_CONST_CHAR_ARRAY",