Commit ab1dfea6 authored Aug 16, 2019 by Wenwen Wang Committed by Greg Kroah-Hartman Sep 21, 2019

dmaengine: ti: omap-dma: Add cleanup in omap_dma_probe()



[ Upstream commit 962411b05a6d3342aa649e39cda1704c1fc042c6 ]

If devm_request_irq() fails to disable all interrupts, no cleanup is
performed before retuning the error. To fix this issue, invoke
omap_dma_free() to do the cleanup.

Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Link: https://lore.kernel.org/r/1565938570-7528-1-git-send-email-wenwen@cs.uga.edu


Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 5a835f51

drivers/dma/omap-dma.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1429,9 +1429,11 @@ static int omap_dma_probe(struct platform_device *pdev)

		rc = devm_request_irq(&pdev->dev, irq, omap_dma_irq,
		IRQF_SHARED, "omap-dma-engine", od);
		if (rc)
		if (rc) {
		omap_dma_free(od);
		return rc;
		}
		}

		if (omap_dma_glbl_read(od, CAPS_0) & CAPS_0_SUPPORT_LL123)
		od->ll123_supported = true;