Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit aad0b624 authored by Dmitry Torokhov's avatar Dmitry Torokhov Committed by Tejun Heo
Browse files

sata_fsl: fix error handling of irq_of_parse_and_map 



irq_of_parse_and_map() returns 0 on error (the result is unsigned int),
so testing for negative result never works.

Signed-off-by: default avatarDmitry Torokhov <dtor@chromium.org>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Cc: stable@vger.kernel.org
parent 249cd0a1

drivers/ata/sata_fsl.c

+1 −1
Original line number Diff line number Diff line
@@ -1488,7 +1488,7 @@ static int sata_fsl_probe(struct platform_device *ofdev) 
	host_priv->csr_base = csr_base;



	irq = irq_of_parse_and_map(ofdev->dev.of_node, 0);

	if (irq < 0) {

	if (!irq) {

		dev_err(&ofdev->dev, "invalid irq from platform\n");

		goto error_exit_with_cleanup;

	}