Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit aab5d313 authored by Sebastian Andrzej Siewior's avatar Sebastian Andrzej Siewior Committed by Greg Kroah-Hartman
Browse files

atm: nicstar: Unmap DMA on send error 



[ Upstream commit 6dceaa9f56e22d0f9b4c4ad2ed9e04e315ce7fe5 ]

The `skb' is mapped for DMA in ns_send() but does not unmap DMA in case
push_scqe() fails to submit the `skb'. The memory of the `skb' is
released so only the DMA mapping is leaking.

Unmap the DMA mapping in case push_scqe() failed.

Fixes: 864a3ff6 ("atm: [nicstar] remove virt_to_bus() and support 64-bit platforms")
Cc: Chas Williams <3chas3@gmail.com>
Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7d6f77b1

drivers/atm/nicstar.c

+2 −0
Original line number Diff line number Diff line
@@ -1707,6 +1707,8 @@ static int ns_send(struct atm_vcc *vcc, struct sk_buff *skb) 


	if (push_scqe(card, vc, scq, &scqe, skb) != 0) {

		atomic_inc(&vcc->stats->tx_err);

		dma_unmap_single(&card->pcidev->dev, NS_PRV_DMA(skb), skb->len,

				 DMA_TO_DEVICE);

		dev_kfree_skb_any(skb);

		return -EIO;

	}